Download files to NERSC on job submission #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job submission code kicks off a coroutine that runs a task at NERSC to do the download. This allows the submission code to return to the user as soon as sanity checks are complete and state is saved. Had to switch the download target from the DTNs to the login node since for some reason `$SCRATCH` and `module` aren't available. Also had to switch the docker compose to host network node so that the service could access the ssh tunnel to Minio.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
==========================================
- Coverage 56.04% 55.74% -0.31%
==========================================
Files 30 31 +1
Lines 1777 1810 +33
==========================================
+ Hits 996 1009 +13
- Misses 781 801 +20 ☔ View full report in Codecov by Sentry. |
Tianhao-Gu
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Job submission code kicks off a coroutine that runs a task at NERSC to do the download. This allows the submission code to return to the user as soon as sanity checks are complete and state is saved.
Had to switch the download target from the DTNs to the login node since for some reason
$SCRATCHandmodulearen't available.Also had to switch the docker compose to host network mode so that the service could access the ssh tunnel to Minio.